fix: avoid spamming a bunch of people while commenting - #9
Conversation
在 CLA 检查到有未签署的人员时,默认行为会 at 所被检查的用户,这对于较大的PR而言会使所有 commit 有被涵盖的用户都被 at,对很多场景而言是不必要的。实际而言,可以只呈现名单,由提交与合入人员自行决策是否要找对应人员签署 CLA。 关联 linuxdeepin/treeland#1215 (comment) Log:
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts CLA comment generation to list committers by name without GitHub mentions, preventing mass notifications while preserving signed/unsigned status information. Flow diagram for updated CLA comment generation (no GitHub mentions)flowchart TD
A[Start CLA comment generation] --> B[Check committersCount > 1]
B --> C[committerMap.signed and committerMap.notSigned exist]
C --> D[Append summary: signed vs total committers]
D --> E[For each signedCommitter: append name with :white_check_mark:]
D --> F[For each unsignedCommitter: append name with :x:]
E --> G[Append retrigger instruction]
F --> G[Append retrigger instruction]
G --> H[Return comment text]
subgraph Legend
L1[Names are listed as plain text]
L2[No @mentions are used]
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- By removing the @ prefix you also lose clickable links to user profiles; if preserving quick access to contributor accounts is important, consider making the mention behavior configurable or only suppressing @-mentions for large PRs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- By removing the @ prefix you also lose clickable links to user profiles; if preserving quick access to contributor accounts is important, consider making the mention behavior configurable or only suppressing @-mentions for large PRs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review★ 总体评分:85分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 diff --git a/src/pullrequest/pullRequestCommentContent.ts b/src/pullrequest/pullRequestCommentContent.ts
index 09f3f410..fb49e860 100644
--- a/src/pullrequest/pullRequestCommentContent.ts
+++ b/src/pullrequest/pullRequestCommentContent.ts
@@ -88,9 +88,9 @@ ${input.getCustomPrSignComment() || "I have read the CLA Document and I hereby s
if (committersCount > 1 && committerMap && committerMap.signed && committerMap.notSigned) {
text += `**${committerMap.signed.length}** out of **${committerMap.signed.length + committerMap.notSigned.length}** committers have signed the CLA.`
- committerMap.signed.forEach(signedCommitter => { text += `<br/>:white_check_mark: ${signedCommitter.name}` })
+ committerMap.signed.forEach(signedCommitter => { text += `<br/>:white_check_mark: @${signedCommitter.name}` })
committerMap.notSigned.forEach(unsignedCommitter => {
- text += `<br/>:x: ${unsignedCommitter.name}`
+ text += `<br/>:x: @${unsignedCommitter.name}`
})
text += '<br/>'
} |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, tsic404 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
在 CLA 检查到有未签署的人员时,默认行为会 at 所被检查的用户,这对于较大的PR而言会使所有 commit 有被涵盖的用户都被 at,对很多场景而言是不必要的。实际而言,可以只呈现名单,由提交与合入人员自行决策是否要找对应人员签署 CLA。
关联 linuxdeepin/treeland#1215 (comment)
Log:
Summary by Sourcery
Bug Fixes: