Skip to content

fix: update systemd service dependencies for ApplicationManager1 #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yixinshark wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

fix: update systemd service dependencies for ApplicationManager1 #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion misc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ install(FILES ${SYSTEMD_USER_FILE} DESTINATION ${SERVICE_DEST_PATH})
install(FILES ${SYSTEMD_USER_DROP_IN_FILE} DESTINATION ${SERVICE_DEST_PATH}/app-DDE-.service.d)

# create a symlink to dde-session
install_symlink(org.desktopspec.ApplicationManager1.service dde-session-initialized.target.wants)
install_symlink(org.desktopspec.ApplicationManager1.service dde-session-core.target.wants)

# # dbus activate
configure_file(
Expand Down
5 changes: 2 additions & 3 deletions misc/systemd/user/org.desktopspec.ApplicationManager1.service.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@ CollectMode=inactive-or-failed
Requisite=dde-session-pre.target
After=dde-session-pre.target

Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the Requisite directive may cause issues with service startup dependencies. The original configuration had Requisite=dde-session-initialized.target, which ensured the service would fail immediately if the target was not active. The new configuration only has PartOf and Before directives for dde-session-core.target, but no Requisite directive.

If dde-session-core.target needs to be active before this service starts (similar to the previous requirement), consider adding Requisite=dde-session-core.target to maintain the strict dependency semantics. Otherwise, if this change is intentional and the service should be able to start regardless of whether dde-session-core.target is active, this should be documented in the commit message to clarify the behavior change.

Suggested change
Requisite=dde-session-core.target

Copilot uses AI. Check for mistakes.
Requisite=dde-session-initialized.target
PartOf=dde-session-initialized.target
Before=dde-session-initialized.target
PartOf=dde-session-core.target
Before=dde-session-core.target

[Service]
Type=dbus
Expand Down