Skip to content

fix(service): register D-Bus object before service name to close race #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzwind merged 1 commit into from
Jul 15, 2026
Merged

fix(service): register D-Bus object before service name to close race #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions logViewerService/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2019 - 2023 UnionTech Software Technology Co., Ltd.
// SPDX-FileCopyrightText: 2019 - 2026 UnionTech Software Technology Co., Ltd.
//
// SPDX-License-Identifier: GPL-3.0-or-later

Expand Down Expand Up @@ -58,16 +58,19 @@ int main(int argc, char *argv[])
Dtk::Core::DLogManager::registerFileAppender();
#endif
QDBusConnection systemBus = QDBusConnection::systemBus();
if (!systemBus.registerService(LogViewrServiceName)) {
qCCritical(logService) << "registerService failed:" << systemBus.lastError();
exit(0x0001);
}
// 先注册对象再注册服务名：well-known name 一旦对外可见，/com/deepin/logviewer
// 对象必然已就绪，消除名称已注册但对象尚未注册的竞态窗口
// （表现为 busctl tree 间歇性 "No such object path '/'"）。
LogViewerService service;
if (!systemBus.registerObject(LogViewrPath,
&service,
QDBusConnection::ExportAllSlots | QDBusConnection::ExportAllSignals)) {
qCCritical(logService) << "registerObject failed:" << systemBus.lastError();
exit(0x0002);
}
if (!systemBus.registerService(LogViewrServiceName)) {
qCCritical(logService) << "registerService failed:" << systemBus.lastError();
exit(0x0001);
}
return a.exec();
}
Loading