Skip to content

fix: remove deepin prefix from Chinese translations in desktop file - #488

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:fix-369185-remove-deepin-from-desktop-i18n
Jul 16, 2026
Merged

fix: remove deepin prefix from Chinese translations in desktop file#488
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:fix-369185-remove-deepin-from-desktop-i18n

Conversation

@add-uos

@add-uos add-uos commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Remove "深度"/"deepin"/"Deepin" prefix from Name/Comment fields in zh_CN, zh_HK, zh_TW translations.

去除 desktop 文件中 zh_CN/zh_HK/zh_TW 翻译的"深度"/"deepin"前缀。

Log: 去除desktop文件中文翻译中的深度/deepin前缀
PMS: BUG-369185
Influence: 自研应用 desktop 文件中文翻译不再包含"深度"/"deepin"品牌前缀。

Summary by Sourcery

Bug Fixes:

  • Correct Chinese desktop entry translations by removing unnecessary "深度"/"deepin" prefixes from Name and Comment fields for zh_CN, zh_HK, and zh_TW.

Remove "深度"/"deepin"/"Deepin" prefix from Name/Comment
fields in zh_CN, zh_HK, zh_TW translations.

去除 desktop 文件中 zh_CN/zh_HK/zh_TW 翻译的"深度"/"deepin"前缀。

Log: 去除desktop文件中文翻译中的深度/deepin前缀
PMS: BUG-369185
Influence: 自研应用 desktop 文件中文翻译不再包含"深度"/"deepin"品牌前缀。
@sourcery-ai

sourcery-ai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Chinese translations in the deepin-log-viewer desktop file to remove the "深度"/"deepin"/"Deepin" brand prefix from the Name and Comment fields for zh_CN, zh_HK, and zh_TW locales.

File-Level Changes

Change Details Files
Clean up Chinese localized Name/Comment strings in the desktop file by removing the deepin brand prefix while keeping the functional part of the text.
  • Updated zh_CN Name field to drop the "深度"/"deepin" prefix from the application name.
  • Updated zh_CN Comment/description field to remove the brand prefix while preserving the description meaning.
  • Applied the same prefix removal to the Name field for zh_HK and zh_TW translations.
  • Applied the same prefix removal to the Comment/description field for zh_HK and zh_TW translations.
application/assets/deepin-log-viewer.desktop

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码实现了繁体中文本地化命名的规范化修正,去除了冗余的品牌前缀
逻辑正确且完全符合桌面入口文件规范,无任何扣分项

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

桌面入口文件采用标准的Key=Value格式,第83行与第84行的Name字段修改后去除了多余的"Deepin "字符串,未破坏等号分隔符及文件结构,语法完全正确
建议:保持当前的修改方式

  • 2.代码质量(优秀)✓

修改前繁体中文的Name字段携带"Deepin"前缀,而简体中文及其他语言未携带,导致风格不统一。此次修改消除了命名风格的不一致,提升了多语言本地化的整体质量
建议:后续新增语言翻译时也应遵循此无品牌前缀的统一规范

  • 3.代码性能(无性能问题)✓

桌面入口文件由桌面环境在应用索引时解析,纯静态字符串的缩短对解析性能无任何负面影响
建议:无需优化

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
纯文本翻译修正,不涉及变量解析、命令执行或路径引用,无任何攻击面

  • 建议:无需安全修复

■ 【改进建议代码示例】

Name[zh_CN]=日志收集工具
Name[zh_HK]=日誌查看器
Name[zh_TW]=日誌收集工具

@lzwind
lzwind merged commit 6e07fde into linuxdeepin:master Jul 16, 2026
22 of 23 checks passed
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants