Skip to content

chore: Update version to 6.5.33 - #489

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master
Jul 16, 2026
Merged

chore: Update version to 6.5.33#489
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master

Conversation

@add-uos

@add-uos add-uos commented Jul 16, 2026

Copy link
Copy Markdown
Contributor
  • update version to 6.5.33

log: update version to 6.5.33

Summary by Sourcery

Chores:

  • Update Debian packaging changelog to reflect version 6.5.33.

- update version to 6.5.33

log: update version to 6.5.33
@sourcery-ai

sourcery-ai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the Debian package changelog to version 6.5.33 and records the corresponding log entry.

File-Level Changes

Change Details Files
Bump Debian package version to 6.5.33 in changelog.
  • Update the version number in the latest debian/changelog entry to 6.5.33.
  • Ensure the changelog log message reflects the new 6.5.33 version.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

Copy link
Copy Markdown
  • 检测到敏感词export变动
详情
    {
    "export": {
        "debian/changelog": {
            "b": [
                "  * fix(security): harden ops log export via fd-based transfer and symlink-safe collection"
            ]
        }
    }
}

@github-actions

Copy link
Copy Markdown

TAG Bot

TAG: 6.5.33
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:95分

■ 【总体评价】

代码正确修复了D-Bus服务注册的竞争条件,逻辑清晰且具备完善的错误处理
修复了潜在的竞争条件问题,仅因变量名拼写瑕疵扣5分

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

logViewerService/main.cppmain() 函数中,代码正确地将 registerObject 调用置于 registerService 之前,确保当服务名对外可见时,D-Bus 对象已经准备好响应请求,有效消除了竞争条件。错误处理逻辑使用 exit() 终止进程并返回特定错误码,符合预期。
潜在问题:无
建议:无

  • 2.代码质量(良好)✓

代码包含了清晰的注释说明修复目的,错误日志输出使用了 qCCritical 并附带 lastError() 信息,便于调试。
潜在问题:宏或变量名 LogViewrPathLogViewrServiceName 存在拼写错误,缺少了字母 'e',应为 LogViewer
建议:修正拼写错误,提高代码可读性和可维护性。

  • 3.代码性能(无性能问题)✓

D-Bus 的对象和服务注册属于服务启动时的一次性初始化操作,不涉及高频调用或循环,对运行时性能没有影响。
潜在问题:无
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
代码通过调整 D-Bus 注册顺序,避免了在服务名注册后但对象未注册期间其他进程调用服务导致的未定义行为或崩溃,提升了系统稳定性。当前代码片段不存在安全漏洞。
建议:无

■ 【改进建议代码示例】

// 修复竞争条件:先注册 D-Bus Object,再注册 Service Name,确保服务名就绪时对象已可响应请求
    LogViewerService service;
    if (!systemBus.registerObject(LogViewerPath,
                                  &service,
                                  QDBusConnection::ExportAllSlots | QDBusConnection::ExportAllSignals)) {
        qCCritical(logService) << "registerObject failed:" << systemBus.lastError();
        exit(0x0002);
    }
    if (!systemBus.registerService(LogViewerServiceName)) {
        qCCritical(logService) << "registerService failed:" << systemBus.lastError();
        exit(0x0001);
    }

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind
lzwind merged commit 4fe404f into linuxdeepin:master Jul 16, 2026
21 of 24 checks passed
@deepin-bot

deepin-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.5.33
  • Tag SHA: 88d5f915feff77a9d2444103b9cd6187b6ea7b0e
  • Commit SHA: 4fe404fb43d7d65abd98cab995c20adba8decdfa
  • Tag Message:
    Release deepin-log-viewer 6.5.33
    
    
  • Tagger:
    • Name: add-uos
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants