chore: add AT-SPI accessibility support for custom widgets - #494
Conversation
Add AT-SPI factory registrations for all custom widget types in accessible.h, enabling accessibility tools to identify these UI elements. * Register 14 custom widget classes with SET_FORM_ACCESSIBLE or SET_BUTTON_ACCESSIBLE in accessible.h * Add explicit accessible names to LogTreeView and status labels in displaycontent.cpp * Add accessible names to sidebar and filter widgets in the SPLITTER_TYPE code path in logcollectormain.cpp * Include UI map and expected element documentation in tests/at/ Log: 添加 AT-SPI 辅助功能支持,注册所有自定义控件的可访问接口 Influence: 影响所有自定义控件的辅助功能识别和 AT 测试定位
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: re2zero The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning
详情 {
"export": {
"application/accessible.h": {
"b": [
"#include \"exportprogressdlg.h\""
]
}
}
} |
Reviewer's GuideAdds AT-SPI accessibility support for deepin-log-viewer’s custom widgets by registering them in the accessibility factory, assigning accessible names/object names to key UI elements, and documenting the expected AT-SPI tree and verification checklist for automated tests. Sequence diagram for AT-SPI lookup using new accessibleFactory registrationssequenceDiagram
actor ATSPIClient
participant QtATSPIBridge
participant accessibleFactory
participant LogTreeView
ATSPIClient->>QtATSPIBridge: request
QtATSPIBridge->>accessibleFactory: accessibleFactory
alt classname is LogTreeView
accessibleFactory->>LogTreeView: USE_ACCESSIBLE
end
accessibleFactory-->>QtATSPIBridge: QAccessibleInterface
QtATSPIBridge-->>ATSPIClient: response
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
✅ 本地验证通过 已在本地子项目
备注(不阻塞,均为既有代码问题,非本 PR 引入): |
PR 验证结果:通过 ✅验证内容仓库: linuxdeepin/deepin-log-viewer 1. cherry-pick ✅
2. 代码 review ✅审查了所有变更(6 个文件,+318 行):
3. 编译验证 ✅
4. 清理 ✅
结论: PR 验证全部通过,可以合并。 |
|
Closing per request - will re-submit with updated workflow constraints |
Summary
Add AT-SPI factory registrations for all custom widget types in the deepin-log-viewer application, enabling accessibility tools (screen readers, AT automation tests) to identify these UI elements properly.
Changes
accessible.h
LogNormalButton, LogIconButton, LogCombox, LogSpinnerWidget,
logDetailInfoWidget, logDetailEdit, ExportProgressDlg,
LogCollectorMain, LogViewHeaderView
displaycontent.cpp
logcollectormain.cpp
Documentation (tests/at/)
Related
Summary by Sourcery
Add AT-SPI accessibility support for all custom widgets in deepin-log-viewer and document the expected accessibility tree.
New Features:
Enhancements:
Documentation: