fix: QtPlayer volume setting - convert int to qreal - #745
Conversation
- Fix setFadeInOutFactor to use proper volume scaling (0.0-1.0 range) - Fix setVolume to divide by 100.0 for correct volume level
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kt286 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @kt286. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts QtPlayer audio output volume handling to use Qt's expected 0.0–1.0 floating-point range and to scale fade-in/out by the current volume, fixing incorrect int-based volume usage. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary by Sourcery
Correct QtPlayer audio output volume handling to use normalized qreal values.
Bug Fixes: