Skip to content

fix: Windows file location support - #746

Open
kt286 wants to merge 1 commit into
linuxdeepin:masterfrom
kt286:fix/show-file-windows
Open

fix: Windows file location support#746
kt286 wants to merge 1 commit into
linuxdeepin:masterfrom
kt286:fix/show-file-windows

Conversation

@kt286

@kt286 kt286 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor
  • Use explorer /select, to open file location on Windows
  • Keep Linux DBus implementation unchanged

Summary by Sourcery

Add OS-specific handling to open a media file's location, using Windows Explorer on Windows while keeping the existing DBus-based approach for Linux.

New Features:

  • Support opening a media file's containing folder and selecting the file via Windows Explorer on Windows.

Bug Fixes:

  • Fix failure to open file locations on Windows by introducing a Windows-specific implementation for showing media file paths.

- Use explorer /select, to open file location on Windows
- Keep Linux DBus implementation unchanged

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @kt286, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kt286

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown

Hi @kt286. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai

sourcery-ai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Implements Windows-specific logic to open a file’s containing folder and select it via Explorer, while preserving the existing Linux DBus behavior for showing file locations.

Sequence diagram for Presenter::showMetaFile platform-specific behavior

sequenceDiagram
    participant Caller
    participant Presenter
    participant QProcess
    participant QDBusInterface

    Caller->>Presenter: showMetaFile(hash)
    Presenter->>Presenter: metaFromHash(hash)
    alt [Q_OS_WIN]
        Presenter->>QProcess: startDetached(explorer, args)
    else [Linux]
        Presenter->>QDBusInterface: call(ShowItems, paths, startupId)
    end
Loading

File-Level Changes

Change Details Files
Add Windows-specific handling in Presenter::showMetaFile to open the file location via Explorer while keeping the Linux DBus path as-is.
  • Include Qt headers needed for desktop services, URLs, and process handling.
  • Guard platform-specific behavior in Presenter::showMetaFile using Q_OS_WIN.
  • On Windows, compute the absolute file path, convert it to native separators, and invoke explorer /select, via QProcess::startDetached.
  • On non-Windows platforms, retain the existing DBus ShowItems call to org.freedesktop.FileManager1.
src/libdmusic/presenter.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants