fix: Windows file location support - #746
Conversation
- Use explorer /select, to open file location on Windows - Keep Linux DBus implementation unchanged
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kt286 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @kt286. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideImplements Windows-specific logic to open a file’s containing folder and select it via Explorer, while preserving the existing Linux DBus behavior for showing file locations. Sequence diagram for Presenter::showMetaFile platform-specific behaviorsequenceDiagram
participant Caller
participant Presenter
participant QProcess
participant QDBusInterface
Caller->>Presenter: showMetaFile(hash)
Presenter->>Presenter: metaFromHash(hash)
alt [Q_OS_WIN]
Presenter->>QProcess: startDetached(explorer, args)
else [Linux]
Presenter->>QDBusInterface: call(ShowItems, paths, startupId)
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary by Sourcery
Add OS-specific handling to open a media file's location, using Windows Explorer on Windows while keeping the existing DBus-based approach for Linux.
New Features:
Bug Fixes: