test(at): fix AT-SPI yaml suites, 14/14 smoke pass - #314
Conversation
Reviewer's GuideThis PR updates AT-SPI YAML suites and element metadata so accessibility automation matches the actual widget roles, names, and focus behavior, while adding accessible names in the C++ UI code for the search box and browser menu, and simplifying/modernizing several menu navigation suites. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
- fix assert element role predicates (framework: dogtail roleName) - fix context menu navigation via AT-SPI focus events fallback - scale menu: use arrow button popup (popup: click) with real item nav - dedup theme menu suite (keep items-style v2) - tab suite: locate page tab by role without hidden parent - add accessible names for BrowserMenu and find search edit Log: fix AT-SPI yaml suites, 14/14 smoke pass PMS: 无
deepin pr auto review★ 总体评分:100分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 // FindWidget.cpp — 增加防御性编程检查,确保内部控件获取安全
void FindWidget::initWidget()
{
qCDebug(appLog) << "Initializing find widget controls";
m_pSearchEdit = new DSearchEdit(this);
m_pSearchEdit->setObjectName("findSearchEdit_P");
m_pSearchEdit->setAccessibleName("Form_findSearchEdit_P");
// 防御性检查:确保 lineEdit() 返回有效指针后再设置属性
if (QLineEdit *pLineEd = m_pSearchEdit->lineEdit()) {
pLineEd->setObjectName("findSearchEdit");
pLineEd->setAccessibleName("DLineEditChildLineEdit");
pLineEd->setFocusPolicy(Qt::StrongFocus);
} else {
qCWarning(appLog) << "FindWidget::initWidget() - DSearchEdit::lineEdit() returned nullptr";
}
connect(m_pSearchEdit, &DSearchEdit::returnPressed, this, &FindWidget::onSearchStart);
connect(m_pSearchEdit, &DSearchEdit::textChanged, this, &FindWidget::onTextChanged);
} |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, re2zero The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/merge |
Smoke: 14 passed, 0 failed. Validate: Gate 1-5 PASS.
Summary by Sourcery
Update AT-SPI accessibility test suites and element mappings to align with current UI semantics, improving reliability of menu, tab, sidebar, scale, and context menu automation.
New Features:
Bug Fixes:
Enhancements:
Tests: