Skip to content

fix: remove deepin prefix from Chinese translations in desktop file - #551

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:fix-369185-remove-deepin-from-desktop-i18n
Jul 16, 2026
Merged

fix: remove deepin prefix from Chinese translations in desktop file#551
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:fix-369185-remove-deepin-from-desktop-i18n

Conversation

@add-uos

@add-uos add-uos commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Remove "深度"/"deepin"/"Deepin" prefix from Name/Comment fields in zh_CN, zh_HK, zh_TW translations.

去除 desktop 文件中 zh_CN/zh_HK/zh_TW 翻译的"深度"/"deepin"前缀。

Log: 去除desktop文件中文翻译中的深度/deepin前缀
PMS: BUG-369185
Influence: 自研应用 desktop 文件中文翻译不再包含"深度"/"deepin"品牌前缀。

Summary by Sourcery

Bug Fixes:

  • Ensure zh_CN, zh_HK, and zh_TW Name/Comment fields in the terminal desktop file no longer include redundant "深度"/"deepin" prefixes.

Remove "深度"/"deepin"/"Deepin" prefix from Name/Comment
fields in zh_CN, zh_HK, zh_TW translations.

去除 desktop 文件中 zh_CN/zh_HK/zh_TW 翻译的"深度"/"deepin"前缀。

Log: 去除desktop文件中文翻译中的深度/deepin前缀
PMS: BUG-369185
Influence: 自研应用 desktop 文件中文翻译不再包含"深度"/"deepin"品牌前缀。
@sourcery-ai

sourcery-ai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Chinese (zh_CN/zh_HK/zh_TW) translations in the deepin-terminal.desktop file to remove the "深度"/"deepin"/"Deepin" branding prefix from Name and Comment fields so that self-developed application desktop entries no longer include the brand prefix in Chinese locales.

File-Level Changes

Change Details Files
Remove the "深度"/"deepin"/"Deepin" branding prefix from Chinese Name/Comment translations in the desktop entry.
  • Update zh_CN Name field to drop any leading brand-related text and keep only the application name/description.
  • Update zh_CN Comment field similarly to remove brand prefixes while preserving the functional description.
  • Apply the same prefix removal pattern to zh_HK and zh_TW Name and Comment translations in the desktop file.
src/deepin-terminal.desktop

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:85分

■ 【总体评价】

代码实现了桌面入口文件的中文本地化名称去品牌化,但存在不符合UOS品牌规范的潜在问题
逻辑正确但因品牌规范一致性风险扣15分

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

具体分析内容:src/deepin-terminal.desktop 文件中的 Name 键值修改符合 Freedesktop.org 桌面入口规范,键名与语言代码后缀(zh_CNzh_HKzh_TW)匹配正确,字符串赋值无语法错误。
潜在问题:无
建议:无

  • 2.代码质量(一般)✕

具体分析内容:去除了简体中文、繁体中文(香港)、繁体中文(台湾)的“深度/Deepin”品牌前缀,但未同步替换为 UOS 品牌标识。在 UOS 操作系统中,系统组件通常要求保留统一的品牌名,此变更会导致启动器、任务栏显示的“终端”与系统其他自带应用(如“UOS文件管理器”)的命名风格不一致。
潜在问题:UOS系统内品牌标识不统一;与用户认知习惯产生偏差
建议:确认产品需求,若合入 UOS 主线,应将品牌词替换为“UOS”而非直接删除

  • 3.代码性能(无性能问题)✓

具体分析内容:仅修改了静态配置文件中的文本字符串,不涉及任何逻辑运算、系统调用或资源分配,对运行时性能无任何影响。
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
总体风险描述:本次变更为纯文本替换,不涉及代码执行、权限变更或外部输入处理,无安全风险。

  • 建议:无需进行安全修复。

■ 【改进建议代码示例】

--- a/src/deepin-terminal.desktop
+++ b/src/deepin-terminal.desktop
@@ -219,9 +219,9 @@ Name[lo]=ເທີມິນັນ
 Name[uk]=Термінал Deepin
 Name[vi]=Deepin Terminal
 Name[lo]=ເທີມິນັນ
-Name[zh_CN]=深度终端
-Name[zh_HK]=Deepin 終端
-Name[zh_TW]=Deepin 終端機
+Name[zh_CN]=UOS终端
+Name[zh_HK]=UOS 終端
+Name[zh_TW]=UOS 終端機
 
 [NewWindow Shortcut Group]
 Exec=deepin-terminal

@lzwind
lzwind merged commit e7bcf81 into linuxdeepin:master Jul 16, 2026
18 checks passed
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants