Skip to content

feat: add entries for newest xdg-terminal-exec spec - #555

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
BLumia:xdg-terminal-exec
Jul 31, 2026
Merged

feat: add entries for newest xdg-terminal-exec spec#555
lzwind merged 1 commit into
linuxdeepin:masterfrom
BLumia:xdg-terminal-exec

Conversation

@BLumia

@BLumia BLumia commented Jul 27, 2026

Copy link
Copy Markdown
Member

See also:

Summary by Sourcery

New Features:

  • Add support for the newest xdg-terminal-exec specification in the deepin-terminal desktop entry.

@BLumia
BLumia requested a review from JWWTSL July 27, 2026 09:04
@sourcery-ai

sourcery-ai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the deepin-terminal desktop entry to comply with the newest xdg-terminal-exec specification by adding/adjusting the appropriate Exec-related entries and metadata in the .desktop file.

File-Level Changes

Change Details Files
Align deepin-terminal .desktop entry with the latest xdg-terminal-exec spec requirements.
  • Update or add Exec/terminal-related keys to match the new xdg-terminal-exec spec fields and semantics
  • Adjust desktop entry metadata (categories, actions, or compatibility keys) as required by the spec
  • Ensure backward compatibility with existing desktop environments while supporting the new spec
src/deepin-terminal.desktop

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@BLumia
BLumia force-pushed the xdg-terminal-exec branch from 341bd68 to beacf66 Compare July 27, 2026 09:09
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:95分

■ 【总体评价】

代码通过新增X-TerminalArgExec和X-TerminalArgDir配置项,修复了外部程序调用终端时的参数传递问题
逻辑正确且符合桌面环境规范,无安全漏洞,仅因配置文件固有的局限性扣除少量分数

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

修改位于 src/deepin-terminal.desktop 文件中,新增的 X-TerminalArgExec=-eX-TerminalArgDir=-w 符合 Desktop Entry 规范,键值对格式正确,无语法错误。
潜在问题:无
建议:无需修改

  • 2.代码质量(优秀)✓

新增的配置项命名清晰,遵循了 XDG 桌面配置项的命名约定,能够准确表达其意图,便于其他桌面环境组件(如文件管理器)解析和调用。
潜在问题:无
建议:无需修改

  • 3.代码性能(无性能问题)✓

该变更为静态配置文件修改,仅在程序启动或被外部程序查询时读取,不涉及运行时性能开销。
潜在问题:无
建议:无需修改

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次修改仅添加终端启动参数声明,不涉及任何用户输入的直接处理或命令拼接,不存在命令注入等安全风险。

  • 建议:无需修复

■ 【改进建议代码示例】

// 当前代码已是最优状态,无需修改
 X-Deepin-Vendor=deepin
 X-Deepin-Singleton=true
 Actions=new-window;quake-mode;
 MimeType=x-scheme-handler/dsg-terminal-exec
 X-TerminalArgExec=-e
 X-TerminalArgDir=-w

@deepin-bot

deepin-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 6.5.40
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #556

@lzwind
lzwind merged commit edafd4a into linuxdeepin:master Jul 31, 2026
18 checks passed
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia
BLumia deleted the xdg-terminal-exec branch August 3, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants