-
Notifications
You must be signed in to change notification settings - Fork 15
sync: from linuxdeepin/dtkcore #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
05250a0 to
4833e32
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
4833e32 to
8366a1c
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
8366a1c to
0d8c3d6
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
0d8c3d6 to
847e158
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
847e158 to
81a530e
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
81a530e to
b02a3f0
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
b02a3f0 to
9cb61b0
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
9cb61b0 to
df42b25
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
df42b25 to
daab7f2
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
daab7f2 to
6298f29
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
6298f29 to
6662bdf
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
6662bdf to
0e09405
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
0e09405 to
970cfdf
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
970cfdf to
e263fd7
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
e263fd7 to
e20259c
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
e20259c to
ecd8569
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
ecd8569 to
e4c6c2e
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
e4c6c2e to
706e843
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
706e843 to
cbb19b7
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
cbb19b7 to
98291ec
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
98291ec to
812146e
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
812146e to
4a61587
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
4a61587 to
70a20ee
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
70a20ee to
666131b
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
666131b to
0a3ea97
Compare
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#531
0a3ea97 to
54ab0f2
Compare
deepin pr auto reviewGit Diff 代码审查报告总体评估这是一个关于DTK(Deepin Tool Kit)核心模块的重要更新,主要涉及版本管理、命名规范和配置系统的重构。改动范围较大,涉及CMakeLists、配置文件和多个源代码文件。整体来看,代码质量有所提升,特别是在线程安全和配置管理方面做了重要改进。 主要变更点
详细分析1. 语法与逻辑优点
潜在问题
2. 代码质量优点
改进建议
3. 代码性能优点
改进建议
4. 代码安全优点
改进建议
具体文件审查CMakeLists.txt
dtkcore.cmake
src/log/dconfig_org_deepin_dtk_preference.hpp
tests/CMakeLists.txt
总结与建议
总体而言,这次更新在版本管理、线程安全和资源管理方面有显著改进,但需要解决一些拼写错误和一致性问题,并加强代码注释和文档更新。 |
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
"line_number": 9,
"rule": "S35",
"reason": "Url link | e18a6b5679"
}
],
"docs/CMakeLists.txt": [
{
"line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
"line_number": 41,
"rule": "S35",
"reason": "Url link | d2deace9b0"
}
]
} |
Synchronize source files from linuxdeepin/dtkcore.
Source-pull-request: linuxdeepin/dtkcore#531