Skip to content

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Oct 23, 2025

  1. Add SCALABLE_SIZE constant for scalable icon directories
  2. Change foundSize return type from uint to int to support scalable detection
  3. Modify writeScaledImage to accept baseSize parameter instead of parsing from directory
  4. Move directory parsing logic to writeImage function for better organization
  5. Add scalable directory detection in size parsing logic
  6. Use QImageReader's scaledSize for better image scaling quality
  7. Fix error handling to continue processing instead of exiting on first error

Log: Improved icon theme generation with better scalable icon support

Influence:

  1. Test with icon directories containing scalable icons
  2. Verify different scale factors work correctly
  3. Test error handling when encountering invalid image files
  4. Verify image quality at various scales
  5. Test with both fixed-size and scalable icon directories

feat: 改进图标主题生成,支持可缩放图标

  1. 添加 SCALABLE_SIZE 常量用于可缩放图标目录
  2. 将 foundSize 返回类型从 uint 改为 int 以支持可缩放检测
  3. 修改 writeScaledImage 函数,接受 baseSize 参数而非从目录解析
  4. 将目录解析逻辑移至 writeImage 函数以获得更好的代码组织
  5. 在尺寸解析逻辑中添加可缩放目录检测
  6. 使用 QImageReader 的 scaledSize 获得更好的图像缩放质量
  7. 修复错误处理,在遇到错误时继续处理而非立即退出

Log: 改进图标主题生成,提供更好的可缩放图标支持

Influence:

  1. 测试包含可缩放图标的目录
  2. 验证不同缩放因子是否正确工作
  3. 测试遇到无效图像文件时的错误处理
  4. 验证各种缩放比例下的图像质量
  5. 测试固定尺寸和可缩放图标目录

1. Add SCALABLE_SIZE constant for scalable icon directories
2. Change foundSize return type from uint to int to support scalable
detection
3. Modify writeScaledImage to accept baseSize parameter instead of
parsing from directory
4. Move directory parsing logic to writeImage function for better
organization
5. Add scalable directory detection in size parsing logic
6. Use QImageReader's scaledSize for better image scaling quality
7. Fix error handling to continue processing instead of exiting on first
error

Log: Improved icon theme generation with better scalable icon support

Influence:
1. Test with icon directories containing scalable icons
2. Verify different scale factors work correctly
3. Test error handling when encountering invalid image files
4. Verify image quality at various scales
5. Test with both fixed-size and scalable icon directories

feat: 改进图标主题生成,支持可缩放图标

1. 添加 SCALABLE_SIZE 常量用于可缩放图标目录
2. 将 foundSize 返回类型从 uint 改为 int 以支持可缩放检测
3. 修改 writeScaledImage 函数,接受 baseSize 参数而非从目录解析
4. 将目录解析逻辑移至 writeImage 函数以获得更好的代码组织
5. 在尺寸解析逻辑中添加可缩放目录检测
6. 使用 QImageReader 的 scaledSize 获得更好的图像缩放质量
7. 修复错误处理,在遇到错误时继续处理而非立即退出

Log: 改进图标主题生成,提供更好的可缩放图标支持

Influence:
1. 测试包含可缩放图标的目录
2. 验证不同缩放因子是否正确工作
3. 测试遇到无效图像文件时的错误处理
4. 验证各种缩放比例下的图像质量
5. 测试固定尺寸和可缩放图标目录
@mhduiy mhduiy requested a review from 18202781743 October 23, 2025 07:16
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 23, 2025
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#351
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy
Copy link
Contributor Author

mhduiy commented Oct 23, 2025

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 23, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 187be9a into linuxdeepin:master Oct 23, 2025
19 of 20 checks passed
mhduiy pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 23, 2025
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants