fix: deleting member fails when removing segments (CM-1312)#4303
Merged
Conversation
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a 500 error on DELETE /member (and the analogous organization path) that occurred when a request included a segment resolving to no active subprojects (e.g., an archived project group). In that case getSegmentSubprojectIds returns an empty array, and building the delete query with segmentId in (:segmentIds) produced invalid SQL (segmentId in ()). The fix adds an early-return guard so the delete is skipped when there are no subproject IDs.
Changes:
- Add an early return in
excludeMembersFromSegmentswhensubprojectIdsis empty. - Apply the same guard in
excludeOrganizationsFromSegments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| backend/src/database/repositories/memberRepository.ts | Guards excludeMembersFromSegments against empty subproject IDs to avoid invalid SQL. |
| backend/src/database/repositories/organizationRepository.ts | Applies the same empty-guard to excludeOrganizationsFromSegments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE
/memberreturns 500 when the request includes a segment that resolves to no active subprojects — e.g. an archived project group. Segment expansion returns an empty list, producing invalid SQL (segmentId in ()).Changes
excludeMembersFromSegmentswhen there are no subproject IDs to deleteexcludeOrganizationsFromSegments