Skip to content

feat(tools): split the semantic layer into discovery and query tools, and add value discovery [LFXV2-2893] #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josep-reyero merged 6 commits into from
Jul 30, 2026
Merged

feat(tools): split the semantic layer into discovery and query tools, and add value discovery [LFXV2-2893] #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3cc056f
fix(tools): correct the regional dimension names and explain metric v…
josep-reyero Jul 28, 2026
e3ccb79
fix(tools): rewrite the semantic layer description around what it can do
josep-reyero Jul 29, 2026
74edac4
refactor(tools): split the semantic layer into discovery and query tools
josep-reyero Jul 29, 2026
325e916
feat(tools): add dimension-value discovery to the semantic layer
josep-reyero Jul 29, 2026
8bb43f0
fix(tools): honour each semantic layer tool name, and drop the sponso…
josep-reyero Jul 29, 2026
525253b
fix(tools): correct stale references and misleading wording in the le…
josep-reyero Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,9 +282,11 @@ Hitting **Connect** will open a browser window for LFID login.

### LFX Lens

| Tool | Description |
|------------------|-------------------------------------------------------------------------------------------------------|
| `query_lfx_lens` | Ask natural-language questions about a project's data (events, contributors, health, value, and more) |
| Tool | Description |
|------------------------------|-------------------------------------------------------------------------------------------------------|
| `query_lfx_lens` | Ask natural-language questions about a project's data (events, contributors, health, value, and more) |
| `explore_lfx_semantic_layer` | Discover Insights metrics and the dimensions available to them |
| `query_lfx_semantic_layer` | Run a metric query against the Insights Semantic Layer (filter, group, rank, trend) |

### B2B Organizations

Expand Down
9 changes: 8 additions & 1 deletion cmd/lfx-mcp-server/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ var defaultTools = []string{
"list_email_templates",
"send_email",
"query_lfx_lens",
"explore_lfx_semantic_layer",
"query_lfx_semantic_layer",
"search_b2b_orgs",
}
Expand Down Expand Up @@ -797,8 +798,14 @@ func newServer(cfg Config, serviceName string, callerToken *auth.TokenInfo) *mcp
if enabledTools["query_lfx_lens"] && canRead && isStaff {
tools.RegisterQueryLFXLens(server)
}
// Each semantic layer tool honours its own name in LFXMCP_TOOLS. They are
// intended to be enabled together — each description points at the other —
// but gating both on one name made the other name select nothing.
if enabledTools["explore_lfx_semantic_layer"] && canRead && isStaff {
tools.RegisterExploreSemanticLayer(server)
}
if enabledTools["query_lfx_semantic_layer"] && canRead && isStaff {
tools.RegisterSemanticLayer(server)
tools.RegisterQuerySemanticLayer(server)
}

return server
Expand Down
Loading
Loading