fix(newsletters): remove dead methods referencing removed bodyPersistable

[andrest50]

Summary

• Removes two private methods (missingDraftRequirements and formatMissing) from newsletter-manage.component.ts that were introduced in feat(meetings): fetch host key from v1_meeting_host_credentials #1196 but call this.bodyPersistable() — a method removed in a prior revert — causing a TS2339 build failure on main.

Ticket

LFXV2-2812

🤖 Generated with Claude Code

[cursor]

PR Summary

Low Risk
Dead-code removal only; no runtime or newsletter save/send logic is modified.

Overview
Removes unused private helpers missingDraftRequirements and formatMissing from newsletter-manage.component.ts. They were left over after bodyPersistable() was removed elsewhere, which caused TS2339 and broke the build on main.

No behavior change—only deletes unreachable code.

^{Reviewed by Cursor Bugbot for commit 9d9a085. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 353b0184-e29d-411b-830e-f87635dd4996

📥 Commits

Reviewing files that changed from the base of the PR and between 08c449f and 9d9a085.

📒 Files selected for processing (1)

• apps/lfx-one/src/app/modules/newsletters/newsletter-manage/newsletter-manage.component.ts

💤 Files with no reviewable changes (1)

• apps/lfx-one/src/app/modules/newsletters/newsletter-manage/newsletter-manage.component.ts

---

Walkthrough

The newsletter management component removes two private helpers that computed and formatted missing draft requirements. No replacement logic or changes to draft saving or sending are shown.

Changes

Newsletter draft cleanup

Layer / File(s)	Summary
Remove obsolete draft feedback helpers apps/lfx-one/src/app/modules/newsletters/newsletter-manage/newsletter-manage.component.ts	Removes missingDraftRequirements() and formatMissing(); the component proceeds directly to goToList() after the preceding audience-email logic.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• linuxfoundation/lfx-self-serve#1201: Changes newsletter save/send eligibility and missing-field feedback in the same component.
• linuxfoundation/lfx-self-serve#1202: Removes the same unused private helper methods.

Suggested labels: ai-assisted

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly reflects the main change: removing obsolete newsletter methods tied to the deleted bodyPersistable helper.
Description check	✅ Passed	The description matches the changeset and explains the TS2339 failure caused by the removed bodyPersistable call.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/LFXV2-2812-build-main

---

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Removes dead newsletter draft-validation helpers that referenced the deleted bodyPersistable() method and caused TS2339 builds to fail.

Changes:

• Removes two unused private helper methods.
• Eliminates the stale bodyPersistable() reference.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.