Skip to content

fix: forward single-value query params in awslambda MultiValueQueryStringParameters #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramwelt merged 2 commits into from
Aug 7, 2026
+9 −2
Merged

fix: forward single-value query params in awslambda MultiValueQueryStringParameters #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e027645
fix: forward single-value query params in awslambda MultiValueQuerySt…
ahmedomosanya Aug 6, 2026
26d1475
Merge branch 'aws-lambda-v2.11' into fix/awslambda-single-value-query…
bramwelt Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/middlewares/awslambda/aws_lambda.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ func valuesToMultiMap(i url.Values) map[string][]string {
values := map[string][]string{}
for name, val := range i {
value, valid := valuesToStrings(val)
if !valid || len(value) == 1 {
if !valid {
continue
}

Expand Down
9 changes: 8 additions & 1 deletion pkg/middlewares/awslambda/aws_lambda_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,14 @@ func Test_AWSLambdaMiddleware_InvokeBasic(t *testing.T) {
assert.Equal(t, http.MethodGet, lReq.HTTPMethod)
assert.Equal(t, "/test/example/path", lReq.Path)
assert.Equal(t, map[string]string{"a": "1", "b": "2"}, lReq.QueryStringParameters)
assert.Equal(t, map[string][]string{"c": {"3", "4"}, "d[]": {"5", "6"}}, lReq.MultiValueQueryStringParameters)
assert.Equal(t, map[string][]string{"a": {"1"}, "b": {"2"}, "c": {"3", "4"}, "d[]": {"5", "6"}}, lReq.MultiValueQueryStringParameters)
// Every inbound query key must reach the Lambda via one of the two forwarded maps;
// none may be silently dropped (regression guard for the single-value strip).
for _, key := range []string{"a", "b", "c", "d[]"} {
_, inSingle := lReq.QueryStringParameters[key]
_, inMulti := lReq.MultiValueQueryStringParameters[key]
assert.Truef(t, inSingle || inMulti, "query key %q missing from forwarded params", key)
}
assert.Equal(t, map[string]string{"Content-Type": "application/json"}, lReq.Headers)
assert.Equal(t, "This is the body", lReq.Body)

Expand Down
Loading