Skip to content

music-control@KopfdesDaemons: Initial release#1826

Open
KopfdesDaemons wants to merge 6 commits intolinuxmint:masterfrom
KopfdesDaemons:music-control
Open

music-control@KopfdesDaemons: Initial release#1826
KopfdesDaemons wants to merge 6 commits intolinuxmint:masterfrom
KopfdesDaemons:music-control

Conversation

@KopfdesDaemons
Copy link
Copy Markdown
Contributor

screenshot

KopfdesDaemons and others added 6 commits April 23, 2026 20:50
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
@github-actions
Copy link
Copy Markdown

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.


Found 1 potential issue(s):

⚠️ sync_file_replace_contents

music-control@KopfdesDaemons/files/music-control@KopfdesDaemons/desklet.js:209

this._trackCoverFileTmp.replace_contents(decoded, null, false, Gio.FileCreateFlags.REPLACE_DESTINATION, null);

Synchronous replace_contents() blocks the main loop.
Use replace_contents_async() instead.


Automated pattern check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant