Bundle lua-resty-string with mod due to broken Alpine deps in 3.24 - #1166
Merged
Conversation
|
PR build pushed to |
Roxedus
approved these changes
Aug 16, 2026
github-project-automation
Bot
moved this from PRs Ready For Team Review
to PRs Approved
in Issue & PR Tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For some reason lua-resty-string in Alpine 3.24 has changed from depending on
nginx-mod-http-luato depending onopenresty-mod-http-lua, which means it can't be installed if nginx is. Thus far none of the other resty packages seem to be affected.Instead we just pull and build the same version of lua-resty-string as Alpine, direct from the upstream repo and bundle it in the mod Dockerfile. Packaged version has been the same all the way back to 3.19 so should be backwards-compatible with older Swag images.
Benefits of this PR and context:
Closes #1165
How Has This Been Tested?
Source / References: