ci: add markdownlint#7
Conversation
isobelmcrae
left a comment
isobelmcrae
left a comment
There was a problem hiding this comment.
why title change :(
| --- | ||
| id: eduroam | ||
| title: "how do i connect to eduroam on <distro>?" | ||
| title: "how do i connect to eduroam on $distro?" |
There was a problem hiding this comment.
wait why did this get changed
There was a problem hiding this comment.
because markdownlint thought it was inline html 💀 i didnt want to disable the whole inline html rule so i just
There was a problem hiding this comment.
ouh........ is there a way we can do like something to indicate insert distro here or....
There was a problem hiding this comment.
yeah thats why idid $distro it matches patterns i have seen where people will say $dayjob and whatnot.
There was a problem hiding this comment.
alr alr its fine then
|
+1 to this pr, but I feel like we should also specify a line length limit for better terminal viewing (wrapping anything over 79 chars is standard I believe) |
i aint fixing allat |
isobelmcrae
left a comment
isobelmcrae
left a comment
There was a problem hiding this comment.
looks fine for time being, will work on fixing line length in another pr !!
Hmm there should be some exceptions for things like long links anyway, so it's probably for the best it's not enforced by CI. Someone should go through and reformat it all though, especially with the number of capitalisation issues. |
you don't like my lowercase? :( |
I don't mind it but every article uses a slightly different capitalisation style, which makes things very much inconsistent, especially around proper nouns |
different authors have different styles, will probably edit it later though for consistency maybe a style guide could be useful |
|
some sort of. markdown style. if you will. |
I think it's better that authors' personal styles come through in their writing, not in their capitalisation but yes, I think a style guide at some point would probably help. |
yes, it was something i just put out quickly - will go fix :> |
3 participants
ugly markdown. lots of trailing whitespace. CI clearly required.