Skip to content

Conversation

@linw1995
Copy link
Owner

Simplify combo reply offload flow by using proper env injection and moving response handling to session server.

Changes:

  • Add set_bash_env/remove_bash_env methods to inject env vars via bash tool instead of string manipulation
  • Move combo reply response handling from TUI stdout parsing to session server socket mechanism
  • Remove redundant error types and JSON parsing logic from TUI

Benefits:

  • Cleaner separation of concerns: session server owns reply response handling
  • More reliable env injection via bash tool API vs string concatenation
  • Simpler TUI code with fewer error cases to manage

- Remove duplicate error variants for coco reply output parsing
- Return Ok(()) from offload handlers and send response via SESSION_SOCK
- Store responder in SessionState and dispatch on successful validation
- Simplify error handling by leveraging server-side validation
@linw1995 linw1995 added the enhancement New feature or request label Jan 18, 2026
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 23.52941% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.73%. Comparing base (e5977ab) to head (87bee25).
⚠️ Report is 9 commits behind head on dev.

Files with missing lines Patch % Lines
crates/coco-tui/src/components/chat.rs 11.32% 47 Missing ⚠️
src/agent/executor.rs 20.00% 8 Missing ⚠️
src/agent.rs 0.00% 6 Missing ⚠️
src/combo/starter.rs 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #106      +/-   ##
==========================================
- Coverage   53.46%   51.73%   -1.73%     
==========================================
  Files          88       91       +3     
  Lines       21248    23373    +2125     
==========================================
+ Hits        11360    12092     +732     
- Misses       9888    11281    +1393     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@linw1995 linw1995 merged commit bd6dbbf into dev Jan 18, 2026
3 checks passed
@linw1995 linw1995 deleted the refactor/move-reply-post-handling-to-session-server branch January 18, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants