Skip to content

Conversation

@nolan-vanmoortel
Copy link

@nolan-vanmoortel nolan-vanmoortel commented Feb 2, 2019

Let me begin by saying thank you for the work done.
Your module binn.js have been very helpful at MintT.

I made a refactoring using the latest concepts of ES6 and in particular on the new Buffer() which are deprecated.
I took advantage of the occasion to apply an eslint-airbnb and tests with chai.js.

-Vanmoortel Nolan

Nolan Vanmoortel added 3 commits February 2, 2019 15:20
REFACTOR TO ES6 LANGUAGE - DONE
REFACTOR TEST TO USE CHAI - DONE
REFACTOR TO ES6 LANGUAGE - DONE
REFACTOR TEST TO USE CHAI - DONE
@kroggen
Copy link
Collaborator

kroggen commented Feb 11, 2019

Hi!

Thank you for the contribution!

Unhappily I cannot accept it on the master branch because it has so many changes, it adds new dependencies and many people still prefer the old Javascript.

So I added a link to your version on the README for ES6 users.

I also recommend using lower case letters on commit messages, unless your company requires the opposite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants