Open
Conversation
hi-hai
reviewed
Jun 27, 2024
Collaborator
|
Have you tested your change? |
Contributor
Author
|
Made changes to the validation:
|
Contributor
Author
|
@hi-hai please review the last push "Router - Get hash improvement" |
hi-hai
reviewed
Jul 5, 2024
hi-hai
reviewed
Jul 5, 2024
CLI Purge URL - Rewrote code to check for blog to switch before sending purge request Change hash function to allow blog switching
hi-hai
reviewed
Jul 8, 2024
hi-hai
reviewed
Jul 8, 2024
| } | ||
|
|
||
| // Test if link can be found. | ||
| if (get_blog_id_from_url($deconstructed['host'], $path) === 0) { |
Collaborator
There was a problem hiding this comment.
This if can be moved to be under line 187's else
Contributor
Author
There was a problem hiding this comment.
This is used for test if subdomain install has the domain url sent
hi-hai
reviewed
Jul 11, 2024
| return; | ||
| } | ||
|
|
||
| $hash = Router::get_hash(self::VALIDATE_PURGE); |
Collaborator
There was a problem hiding this comment.
This should be under the cond $action == Core::ACTION_QS_PURGE, otherwise it will update hash value for all verify_action()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed cli command:
wp --url=http://test.com/url litespeed-purge urlWhen using Multisite and behind LiteSpeed Web ADC