fix: resolve SSE streaming header duplication and event ID continuity#8
Merged
fix: resolve SSE streaming header duplication and event ID continuity#8
Conversation
- Move HTTP header setup outside the loop in chatStreamResponseLoop to set only once - Add chunkIdx field to maintain global incrementing event IDs across tool call loops - Fix ConversationID assignment in non-SSE mode (cm.ID -> ccr.cs.GetID()) - Fix tool_calls detection logic using FinishReasonToolCalls strong type - Add llm.FinishReason type definition and constants Other: - Make Provider.URL a required config
liut
added a commit
that referenced
this pull request
Mar 13, 2026
- Add Tools map to Preset struct for custom tool descriptions - Add ApplyToolDescriptions method to Registry - Update README with new preset configuration examples Closes: #8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chunkIdxfield to maintain global incrementing IDscm.ID→ccr.cs.GetID())FinishReasonToolCallsllm.FinishReasontype definition and constantsChanges
pkg/web/api/handle_convo.go: Move HTTP header setup tochatStreamResponseLoop, useccr.chunkIdxfor SSE event IDspkg/services/llm/types.go: AddFinishReasontype and constantspkg/services/llm/openai.go: UseFinishReasontype for stream responsepkg/settings/config.go: MakeProvider.URLrequired