Fix window close functionality and mutable default argument anti-pattern #3314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs identified in the codebase:
Bug 1: Non-functional window close method in DevRenderer
The
DevRenderer::Close()method inlivekit-plugins-browserhad its core functionality commented out, making it effectively a no-op:This prevented the development window from being properly closed when the Close method was called. The fix uncomments the
glfwSetWindowShouldClosecall to restore proper window closing behavior.Bug 2: Mutable default argument in log_exceptions decorator
The
log_exceptionsfunction inlivekit-agentsused a mutable default argument anti-pattern:This creates the logger at function definition time rather than call time, which can lead to unexpected behavior if logging configuration changes after the function is defined. The fix changes this to:
This follows Python best practices by avoiding mutable default arguments and ensures a fresh logger is obtained each time the function is called with the default value.
Both fixes are minimal, surgical changes that restore proper functionality without affecting the existing API or breaking backward compatibility.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.