fix(proguard): scope protobuf keep rule to SDK-generated messages#975
Open
adrian-niculescu wants to merge 1 commit into
Open
fix(proguard): scope protobuf keep rule to SDK-generated messages#975adrian-niculescu wants to merge 1 commit into
adrian-niculescu wants to merge 1 commit into
Conversation
The rule matched every GeneratedMessageLite subclass in the consuming app, keeping fields for the app's own protos and unrelated protobuf libraries. Scope it to livekit.** and the com.google.protobuf.** well-known types the SDK's messages embed.
adrian-niculescu
requested review from
MaxHeimbrock,
davidliu and
xianshijing-lk
as code owners
🦋 Changeset detectedLatest commit: 1738e0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protobuf keep rule matched
class * extends GeneratedMessageLite, so it keeps<fields>for every protobuf message in the consuming app, including the app's own protos and unrelated protobuf-using libraries. A consumer rule should only keep what the SDK itself needs.This scopes it to
livekit.**for the SDK's generated messages andcom.google.protobuf.**for the well-known types they embed (Timestampand friends). protobuf-javalite resolves those fields reflectively by name, so both scopes are required.Tested by deploying an optimized release build of an app that uses the SDK to real devices on Android 13 and Android 17 (latest beta). LiveKit worked as expected with these changes.