Log redis sentinel messages as debug level #1252
Open
maurice2k wants to merge 1 commit into
Open
Conversation
go-redis writes Sentinel discovery diagnostics to stderr by default. In Egress handler processes, stderr is consumed by HandlerLogger and any unparsed line is emitted as an error, which turns expected parallel Sentinel lookup cancellation into misleading error logs. Install a go-redis logger backed by the Egress logger so Redis diagnostics keep their own severity. Expected Sentinel discovery chatter is logged at debug while real Redis diagnostics remain visible as warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-redis writes Sentinel discovery diagnostics to stderr by default. In Egress handler processes, stderr is consumed by HandlerLogger and any unparsed line is emitted as an error, which turns expected parallel Sentinel lookup cancellation into misleading error logs.
Install a go-redis logger backed by the Egress logger so Redis diagnostics keep their own severity. Expected Sentinel discovery chatter is logged at debug while real Redis diagnostics remain visible as warnings.