Report upload error status in metrics#1264
Merged
Merged
Conversation
Contributor
|
AV-sync stats summary: view in run #28048493260 |
boks1971
approved these changes
Jun 17, 2026
milos-lk
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pipeline_uploadsfailure counter with the HTTP status class (4xx,5xx, orinternal) instead of a singlefailurevalue, so user errors (bad creds, missing bucket, access denied) can be distinguished from infrastructure issues.errors.As(&storage.ErrorWithStatusCode{}).ErrUploadFailedto%wso the underlying storage error is preserved through the wrap.Dependencies
Depends on livekit/storage#30 (introduces
storage.ErrorWithStatusCode). go.mod currently has a localreplacepointing at../storageso the branches can be reviewed together; this will be dropped once the storage PR merges.Test plan
go test ./pkg/pipeline/sink/uploader/...— newTestUploadErrorHasStatusCodecovers 4xx and 5xx S3 responses.pipeline_uploadsPrometheus metric showsstatus={success,4xx,5xx,internal}in a real egress run.🤖 Generated with Claude Code