Revise CPU cost settings in README#1267
Open
devniel wants to merge 1 commit into
Open
Conversation
Updated CPU cost estimation parameters for egress requests.
biglittlebigben
left a comment
biglittlebigben
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch! May I suggest you set the default values in the example as they are typically good starting point?
Particularly, I believe 100 pulse clients is above the threshold that would cause the pulse library to fail opening new sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Livekit,
The cpu_cost example is outdated, I'm adding here all the available values and comments.
Please review it.