fix(connector): redact phone numbers from logs #1357
Conversation
|
|
|
||
| message DialWhatsAppCallRequest { | ||
| // Required - The number of the business that is initiating the call | ||
| // Required - The phone number id of the business that is initiating the call |
There was a problem hiding this comment.
Added a note to make it more clear that it is an id and not a phone number.
On a side note, I have not redacted it since it's not PII
| // Optional - Agents to dispatch the call to | ||
| repeated RoomAgentDispatch agents = 6; | ||
| // Optional - Identity of the participant in LiveKit room | ||
| // This is used for logging purposes, so it is advised to not put PII in this field. |
There was a problem hiding this comment.
Added this note because it's easy to put PII in this field, I've made that mistake myself
| string whatsapp_phone_number_id = 1; | ||
| // Required - The number of the user that is supossed to receive the call | ||
| string whatsapp_to_phone_number = 2; | ||
| string whatsapp_to_phone_number = 2 [(logger.redact) = true]; |
There was a problem hiding this comment.
sip logs phone numbers everywhere - sip participant identities are phone numbers. it seems like we don't care about redacting this
There was a problem hiding this comment.
There are open linear tickets to redact these in SIP as well
No description provided.