Fix for dynacast error#1213
Open
MaxHeimbrock wants to merge 4 commits into
Open
Conversation
Contributor
ChangesetThe following package versions will be affected by this PR:
|
c6d1fb5 to
128f39f
Compare
ladvoc
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When using dynacast: black video in calls (no frames ever arrive; the texture stays black) and the test failure (it
times out with zero frames — "no metadata" was really "no frames at all")
Proof:
packet_trailer_test.rsfails when dynacast is onRoot cause
set_publishing_layers in client-sdk-rust~/livekit/src/room/track/local_video_track.rs:372 mishandles non-simulcast tracks (one encoding, empty rid):
dynacast: SFU quality update for TR_V...: subscribed_codecs="vp8:[Low=true, Medium=false, High=false]"
dynacast: layers changed -> [(High)=off]