Pass Interceptors to Subscriber PeerConnection for Stats Collection

[terran-vigil-simplisafe]

The createSubscriberPCLocked does not pass Interceptors from e.connParams to the subscriber PeerConnection. Note that createPublisherPCLocked does do this.
This prevents interceptors (in our case, Pion WebRTC stats interceptor) from being applied to the subscriber, causing inbound-rtp statistics to be missing when GetStats() is called on the subscriber PeerConnection.

[anunaym14]

LGTM, but I just want to double-check if this was done intentionally

[terran-vigil-simplisafe]

LGTM, but I just want to double-check if this was done intentionally

Yes, it was intentional. It was the only way I could see to capture the metrics I needed.

[anunaym14]

Yes, it was intentional. It was the only way I could see to capture the metrics I needed.

Sorry, I meant if leaving it out of subscriber peer connection in the first place was intentional or not

[terran-vigil-simplisafe]

Ah, got it thanks :)

[boks1971]

Interceptors are applied as either the default ones or user supplied -

server-sdk-go/transport.go

Lines 171 to 179 in 9ea8d56

	if params.Interceptors != nil {
	for _, c := range params.Interceptors {
	i.Add(c)
	}
	} else {
	err := t.registerDefaultInterceptors(params, i)
	if err != nil {
	return nil, err
	}

.

There are important ones like NACK sender, RTCP reports which are registered as part of default.

The publisher PC case was a specific use case and it is used with no interceptors but API is more generic to have user supplied interceptors.

For stats, it might be better to add another option to specify if the stats interceptor should be registered and register it as part of default interceptor registration if enabled.

[terran-vigil-simplisafe]

I've updated the PR to include support for an additional param 'IncludeDefaultInterceptors' that does what I think boks1971 suggested. It appears to work in my project when I use the new param.

[boks1971]

looks good overall,

this formatting looks off, can you please check that?

[terran-vigil-simplisafe]

Done. Thanks