Skip to content

feat(lookml): add single-file push and pull options - #40

Merged
bwebs merged 3 commits into
mainfrom
bryan/single-file-push-and-verison
Jul 14, 2026
Merged

feat(lookml): add single-file push and pull options#40
bwebs merged 3 commits into
mainfrom
bryan/single-file-push-and-verison

Conversation

@bwebs

@bwebs bwebs commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds single-file synchronization support to lkr tools lookml push and lkr tools lookml pull.

  • Added --file / -f options to both commands.
  • push: Syncs only the specified file and skips remote orphan deletion. Also supports passing a single file path directly as the positional argument.
  • pull: Pulls only the specified file and skips local orphan deletion.
  • Added comprehensive unit tests for single-file push and pull operations.
  • Added --version option to CLI.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a --version option to the main CLI and adds support for pushing and pulling a single file via a new --file / -f option in the lookml tools. The review feedback highlights critical issues in the single-file implementation: a bug in push where passing a file as the main argument duplicates the directory prefix, a path traversal vulnerability in the push command, and a path resolution/traversal issue in the pull command.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lkr/tools/lookml.py
Comment thread lkr/tools/lookml.py
Comment thread lkr/tools/lookml.py
@bwebs
bwebs merged commit b04171a into main Jul 14, 2026
1 check passed
@bwebs
bwebs deleted the bryan/single-file-push-and-verison branch July 14, 2026 21:38
bwebs added a commit that referenced this pull request Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant