fix(auth): persist updated refresh_token and refresh_expires_at on token refresh - #42
Merged
Conversation
…ken refresh (Fixes #41)
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the token storage logic in auth_service.py to persist the refresh_token and its expiration timestamp in the database, with corresponding updates to the test suite. The review feedback points out that refresh_expires_at should only be updated when a new refresh_token is actually returned, to avoid mismatching the server's actual token validity when the refresh token is not rotated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where renewing or refreshing tokens did not update or save
refresh_tokenandrefresh_expires_atin the database.Changes
CurrentAuth.set_token()(lkr/auth_service.py), updated the SQLUPDATE authstatement to persistrefresh_tokenandrefresh_expires_atalongsideaccess_tokenandtoken_type.CurrentAuthwhen a newrefresh_tokenis present.tests/test_oauth_account.pyverifying thatrefresh_tokenis updated in SQLite after token refresh.Fixes #41