feat(codemode): allow injecting variables into sandbox execution context - #44
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new --var (or -v) option to the sandbox command in lkr code-mode, allowing users to inject key-value variables directly into the executed Python script. It also updates the documentation across several files (codemode.md, lkr.md, and lkr/codemode/readme.py) to reflect this new feature, as well as documenting the --version option and the single-file -f/--file option for LookML push/pull commands. Feedback is provided on lkr/codemode/main.py to add validation for the injected variables, ensuring they contain an = character and that the keys are valid Python identifiers, preventing silent failures or syntax errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a repeatable
--var / -vkey=value parameter tolkr code-mode sandboxto define top-level variables inside the Python script execution context.Closes #43
Summary of Changes
var: list[str] | Noneoption (--var/-v) to thesandboxCLI command inlkr/codemode/main.py.codemode.md,lkr/codemode/readme.py, and regeneratedlkr.mdCLI specs.