refactor!: change image_name to distro_name in StackConfig #4396
+84
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdoern
requested review from
ashwinb,
bbrowning,
ehhuang,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
meta-cla
bot
added
the
CLA Signed
cdoern
force-pushed
the
image_name
branch
3 times, most recently
from
6fed7ac to
c5e9806
Compare
image_name seems like a misnomer, typically image_name is just the name of the distribution, the config file, or providers-run. This should probably not be called an `image_name` Signed-off-by: Charlie Doern <cdoern@redhat.com>
leseb
reviewed
Dec 16, 2025
Collaborator
leseb
left a comment
leseb
left a comment
There was a problem hiding this comment.
wondering if we should continue to expose image_name but set deprecated in the Pydantic Field. 🤔 - we can still recommend distro_name as the new name though for all the templates.
raghotham
approved these changes
Jan 5, 2026
Collaborator
|
@cdoern are you planning to address #4396 (review)? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
image_name seems like a misnomer, typically image_name is just the name of the distribution, the config file, or providers-run. This should probably not be called an
image_name