DRAFT feat: Adding Oci 26ai Vector Support #4411
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rriley99-oci
requested review from
ashwinb,
bbrowning,
cdoern,
ehhuang,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
meta-cla
bot
added
the
CLA Signed
| @@ -0,0 +1,342 @@ | |||
| { | |||
| "cells": [ | |||
Collaborator
There was a problem hiding this comment.
Do we need a notebook for this? Can't we jsut put this in the regular docs?
Contributor
There was a problem hiding this comment.
@franciscojavierarceo we've been chatting with @omaryashraf5 about this a bit, notebooks aren't necessarily needed but are much nicer to follow as a guarantee of correct setup than a document. I'd be curious to hear your thoughts.
Collaborator
There was a problem hiding this comment.
Yeah I would say that a broader notebook should be fine but vector stores. behave approximately equivalently for all providers so we wouldn't need one specific to OCI 26ai, but we could have specific documentation to outline important implementation details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a draft so I can ask some questions for now. I will remove "DRAFT" when its ready for review.
Test Plan