-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(api): migrate Eval API to FastAPI router (#4345) #4425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(api): migrate Eval API to FastAPI router (#4345) #4425
Conversation
✱ Stainless preview buildsThis PR will update the Edit this comment to update it. It will appear in the SDK's changelogs. ✅ llama-stack-client-node studio · code · diff
❗ llama-stack-client-kotlin studio
✅ llama-stack-client-python studio · code · diff
✅ llama-stack-client-go studio · code · diff
⏳ These are partial results; builds are still running. This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
|
This pull request has merge conflicts that must be resolved before it can be merged. @r-bit-rry please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
b343911 to
1870c46
Compare
| }, | ||
| ) | ||
| async def run_eval( | ||
| benchmark_id_request: Annotated[BenchmarkIdRequest, Depends(get_benchmark_id_request)], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to reviewers, I wanted to use the Annotated for the entire request but the create_path_dependency function only works with single-field models, JobStatusRequest, JobCancelRequest, and JobResultRequest each have two path parameters (benchmark_id and job_id).
|
@leseb Continuing on our effort here |
|
This pull request has merge conflicts that must be resolved before it can be merged. @r-bit-rry please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
Migrates the Eval API from
@webmethoddecorators to FastAPI routers, following the pattern established by Batches (#4191) and Benchmarks (#4309) migrations.Changes
src/llama_stack_api/eval/withapi.py,models.py,fastapi_routes.pysrc/llama_stack_api/eval.pywith@webmethoddecoratorsMigrated Endpoints
/eval/benchmarks/{benchmark_id}/jobs/eval/benchmarks/{benchmark_id}/evaluations/eval/benchmarks/{benchmark_id}/jobs/{job_id}/eval/benchmarks/{benchmark_id}/jobs/{job_id}/eval/benchmarks/{benchmark_id}/jobs/{job_id}/resultTesting
Closes #4345