Remove redundant __has_include check in policy test#184
Merged
koparasy merged 2 commits intofeatures/policyfrom Dec 18, 2025
Merged
Remove redundant __has_include check in policy test#184koparasy merged 2 commits intofeatures/policyfrom
koparasy merged 2 commits intofeatures/policyfrom
Conversation
Merged
Co-authored-by: koparasy <1258022+koparasy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on 'Add policy concept' PR
Remove redundant __has_include check in policy test
Dec 18, 2025
koparasy
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on PR #183 regarding unnecessary conditional compilation in
tests/AMSlib/wf/policy.cpp.The file unconditionally includes
wf/layout_transform.hppat line 11, making the#if __has_include("wf/layout_transform.hpp")guard around theDummyLayoutclass methods redundant—compilation would have already failed if the header was unavailable.Changes:
#if __has_include("wf/layout_transform.hpp")/#endifwrapper fromDummyLayout::pack()andDummyLayout::unpack()methods✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.