Break up ui.py into seperate class-only python files.#27
Open
jdunns wants to merge 11 commits into
Open
Conversation
for more information, see https://pre-commit.ci
…emove the ThemeColors object.
Open
for more information, see https://pre-commit.ci
…tion. Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
…st, and update the project urls.
nightlark
changed the title
jdunns
commented
Jun 10, 2026
| _theme_colors = None | ||
|
|
||
|
|
||
| class ThemeColors: |
Contributor
Author
There was a problem hiding this comment.
This object was what I deleted instead of working to copy and pass it to each UI class. I found it to be completely unnecessary since the dark theme is set at the initial window creation and the colors can be referenced from the ttkbootstrap Colors object much more elegantly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #26 .
This is almost a 1:1 copy of all classes in the massive ui.py file. Each class was broken out into their own python file. The only modification other than fixing imports was removing the ThemeColors object which was completely unnecessary. I decided to remove it rather than try and pass the colors from the global variable in ui,py to each of the classes no longer in that file.
This merge request shouldn't be reviewed until #25 is merged in since I branched off of that feature branch (I did not want to face new ruff errors later and merge conflicts if I could help it).