unify length scales in Intersection2DPolygon - #230
Open
ebchin wants to merge 2 commits into
Open
Conversation
white238
reviewed
Aug 4, 2026
| * \param [in] numVertexB number of vertices in polygon B | ||
| * \param [in] posTol position tolerance to collapse segment-segment intersection points | ||
| * \param [in] lenTol length tolerance to collapse short intersection edges | ||
| * \param [in] lengthTol nondimensional length tolerance used directly for point-in-face barycentric checks and |
Member
There was a problem hiding this comment.
Congrats on the longest parameter description I've seen!
white238
approved these changes
Aug 4, 2026
white238
left a comment
white238
left a comment
Member
There was a problem hiding this comment.
Was this what was exposed by the submodule PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the cause of #229 for the geometry identified. Tolerances in
Intersection2DPolygon()are used inconsistently. Specifically for the geometry identified, this causes a tolerance for determining if one polygon is not contained another to not be triggered, but a similar tolerance checking if the points should be collapsed to be triggered down the line. Between the two checks,PolyReorderConvex()is called, but since the geometry contains non-collapsed points, it is not convex, causing the routine to fail.This PR includes 2 fixes:
Intersection2DPolygon()consistentPolyReorderConvex()