Fixes formatting of reference and pointer variables - #1930
Open
kennyweiss wants to merge 3 commits into
Open
Conversation
kennyweiss
requested review from
Arlie-Capps,
BradWhitlock,
bmhan12,
doutriaux1,
jcs15c,
nselliott,
publixsubfan,
rhornung67 and
white238
July 29, 2026 02:02
kennyweiss
commented
Jul 29, 2026
Member
Author
There was a problem hiding this comment.
This file contains the only hand-edited changes.
Many of the changes were related to removing obsolete/deprecated features, and updating to the new ones.
Tested using clang-format --dump-config
The rest of the files in this PR are automatically generated via make style
(Note: Reviewing with "Hide whitespace" reveals that nearly every change in this PR is a whitespace change.)
kennyweiss
commented
Jul 29, 2026
Comment on lines
+53
to
+55
| PointerAlignment: Left | ||
|
|
||
| ReferenceAlignment: Left |
Member
Author
There was a problem hiding this comment.
These two control the placement of T* ptr and T& ref
The DerivePointAligment: false a few lines up says not to use the style found in the file.
kennyweiss
marked this pull request as ready for review
July 29, 2026 02:11
rhornung67
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*and&for pointers and references next to the type rather than the variableSince this merge will affect all outstanding existing branches, it probably makes sense to merge this close to the upcoming August release.