[1277] - Add remaining Laghos problems to benchpark#1278
Conversation
267af62 to
d3dbf15
Compare
bfe7258 to
6207c3c
Compare
6207c3c to
e24d7d9
Compare
|
Update: I confirm testing the two remaining problems and they both finished successfully. I tested with a backup branch forked from this feature branch and this forked branch has been rebased on ===== Update: Rebased on hip-wrapper, still facing same issue: ===== This has been tested for 6/8 different Laghos problems with different configs and params from what we added. It's ready for review, but I'll make sure its not merged until the remaining two problems are tested, blocked by the |
michaelmckinsey1
left a comment
There was a problem hiding this comment.
Since this is working for everything but rocm/7, I would say this is not blocked by the hip-wrapper branch. Because we can still use it on the other architectures and rocm6.
So once this PR is ready, I think we can merge it independent of #1266. Also @scheibelp said 1266 won't likely get merged anyway, it will be fixed in an upstream spack PR (#49673), which will take longer than the benchpark PR to merge.
f2cdf80 to
66201fc
Compare
0f151af to
4cd8aa9
Compare
|
@michaelmckinsey1 please review and let me know when this is ready for my review. |
michaelmckinsey1
left a comment
There was a problem hiding this comment.
application.py looks fine now that we have common_args, much more succinct.
|
@michaelmckinsey1 please re-review, and remove the "changes requested" label when you resolve all requests and approve the PR. |
0f7af3e to
a405c90
Compare
michaelmckinsey1
left a comment
There was a problem hiding this comment.
Looks good, given the Laghos gitlab tests that are running are successful
…-laghos-problems-to-benchpark
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1278 +/- ##
===========================================
+ Coverage 62.48% 64.04% +1.56%
===========================================
Files 49 49
Lines 3774 3774
Branches 326 326
===========================================
+ Hits 2358 2417 +59
+ Misses 1402 1343 -59
Partials 14 14 🚀 New features to boost your workflow:
|
Resolves #1277