[WIP] Fix nightly tests#1302
Closed
rfhaque wants to merge 1 commit into
Closed
Conversation
…k once we support Kokkos 5.0.2
michaelmckinsey1
requested changes
Apr 20, 2026
michaelmckinsey1
left a comment
michaelmckinsey1
left a comment
Collaborator
There was a problem hiding this comment.
Why are we removing lammps?
Collaborator
Author
The develop version of lammps requires Kokkos v5.0.2. The spack commit in benchpark (as of 04/20/2026) only supports Kokkos v5.0.0 |
Collaborator
So would it be appropriate to bump the spack-packages version instead? I see the upstream spack-packages has v5.0.2 |
Collaborator
Author
|
Create a new PR after #1318 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes nightly test failures in benchpark
Adding/modifying core functionality, CI, or documentation:
.github/workflowsand.gitlab/testsunit tests (if needed)