Closed
Conversation
rayandrew
requested review from
Copilot and
hariharan-devarajan
and removed request for
Copilot
hariharan-devarajan
requested changes
Feb 20, 2026
Member
hariharan-devarajan
left a comment
hariharan-devarajan
left a comment
There was a problem hiding this comment.
We should remove all instances of level and level Mtx
rayandrew
force-pushed
the
feat/remove-level-tracking
branch
from
489ed3e to
630fc3a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Removes DFTLogger’s level-based event tracking because it’s unreliable, simplifying event indexing and metadata behavior.
Changes:
- Removed level/stack state (
level,index_stack) and related locking. - Dropped level/parent index metadata injection (
level,p_idx). - Simplified “current event index” handling to use the atomic
index.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rayandrew
force-pushed
the
feat/remove-level-tracking
branch
from
630fc3a to
9987870
Compare
rayandrew
force-pushed
the
feat/remove-level-tracking
branch
from
9987870 to
895f86f
Compare
Collaborator
Author
|
closed since this is merged to #338 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #337
This PR removes the level tracking on dftracer since it is not reliable.