[PAC][lld] Do not emit AUTH relocs against undef weak non-preemptible symbols#194636
Draft
kovdan01 wants to merge 2 commits into
Draft
Conversation
kovdan01
force-pushed
the
users/kovdan01/lld-pauth-undef-weak
branch
from
56a1e51 to
0bb1eb1
Compare
Contributor
Author
|
Ensured pauthtest buildbot is passing (including llvm-test-suite run): https://lab.llvm.org/buildbot/#/builders/227/builds/1828 |
kovdan01
force-pushed
the
users/kovdan01/lld-pauth-undef-weak
branch
from
0bb1eb1 to
79a0c1d
Compare
Contributor
Author
|
The CI checks are expected to fail unless the dependency #198327 is merged |
🐧 Linux x64 Test Results
✅ The build succeeded and all tests passed. |
🪟 Windows x64 Test Results
✅ The build succeeded and all tests passed. |
kovdan01
changed the base branch from
main
to
users/kovdan01/pauth-tlsdesc-call-reloc
kovdan01
force-pushed
the
users/kovdan01/lld-pauth-undef-weak
branch
from
79a0c1d to
727f788
Compare
kovdan01
added a commit
that referenced
this pull request
May 25, 2026
The R_AARCH64_AUTH_TLSDESC_CALL is introduced to allow linker relaxation of AUTH TLSDESC call sequences for non-preemptible undefined weak symbols. The lld patch introducing the relaxation: #194636 Corresponding ARM docs PR: ARM-software/abi-aa#395
kovdan01
added a commit
that referenced
this pull request
May 25, 2026
The R_AARCH64_AUTH_TLSDESC_CALL is introduced to allow linker relaxation of AUTH TLSDESC call sequences for non-preemptible undefined weak symbols. The lld patch introducing the relaxation: #194636 Corresponding ARM docs PR: ARM-software/abi-aa#395
… symbols Undefined weak non-preemptible symbols should be statically resolved to the addend value and not signed. Previously, a dynamic relocation against such symbols was emitted, which is not a correct behavior. See also docs: ARM-software/abi-aa#391 Resolves #173296
kovdan01
force-pushed
the
users/kovdan01/lld-pauth-undef-weak
branch
from
727f788 to
565d156
Compare
kovdan01
changed the base branch from
users/kovdan01/pauth-tlsdesc-call-reloc
to
users/kovdan01/llvm-support-auth-tlsdesc-call-rel
Contributor
Author
|
Ensured pauthtest buildbot is passing (including llvm-test-suite run): https://lab.llvm.org/buildbot/#/builders/227/builds/2008 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undefined weak non-preemptible symbols should be statically resolved to the addend value and not signed. Previously, a dynamic relocation against such symbols was emitted, which is not a correct behavior.
See also docs: ARM-software/abi-aa#391
Depends on: #198327
Resolves #173296