[CI] Promote AMD and NVIDIA DirectX targets out of experimental#1187
Open
alsepkow wants to merge 5 commits into
Open
[CI] Promote AMD and NVIDIA DirectX targets out of experimental#1187alsepkow wants to merge 5 commits into
alsepkow wants to merge 5 commits into
Conversation
Both AMD and NVIDIA DirectX configurations have been stable and have higher pass rates than the existing Tier 1 Intel target. Promote them to Tier 1 so they run on every PR. Qualcomm and the Vulkan IHV configurations remain experimental and continue to require the 'test-all' label. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
alsepkow
force-pushed
the
promote-dx-targets
branch
from
af63cf9 to
cab55cf
Compare
Match the tier change in docs/CI.md and pr-matrix.yaml so the README status table reflects that these targets now run on every PR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
farzonl
approved these changes
May 13, 2026
Member
|
Thank you Alex! |
bob80905
approved these changes
May 13, 2026
| matrix: | ||
| SKU: [windows-intel] | ||
| TestTarget: [check-hlsl-d3d12, check-hlsl-vk, check-hlsl-clang-d3d12, check-hlsl-clang-vk] | ||
| include: |
Contributor
There was a problem hiding this comment.
nit:
You might consider something like this:
matrix:
SKU: [windows-intel, windows-amd, windows-nvidia]
TestTarget: [check-hlsl-d3d12, check-hlsl-vk, check-hlsl-clang-d3d12, check-hlsl-clang-vk]
exclude:
- { SKU: windows-amd, TestTarget: check-hlsl-vk }
- { SKU: windows-amd, TestTarget: check-hlsl-clang-vk }
- { SKU: windows-nvidia, TestTarget: check-hlsl-vk }
- { SKU: windows-nvidia, TestTarget: check-hlsl-clang-vk }
so that as future test targets get promoted, we can just remove exclusions, rather than needing to add specific inclusions. Something about this seems cleaner to me.
Contributor
Author
There was a problem hiding this comment.
This does seem cleaner to me assuming the expected state would eventually be that we don't have exclusions.
Per Bob's review feedback, switch from listing AMD/NVIDIA D3D12 combinations via 'include' to a cross-product with 'exclude' for the AMD/NVIDIA Vulkan combinations. As future targets get promoted out of experimental, we can simply remove exclusions rather than adding inclusions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Apply the same cross-product + exclude pattern to the experimental Exec-Tests-Extra job for consistency. As targets are promoted out of experimental, exclusions can be added here in lockstep with their removal from the Tier 1 Exec-Tests-Windows job. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This reverts commit 1eec3eb. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bob80905
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both AMD and NVIDIA DirectX configurations have been stable and have higher pass rates than the existing Tier 1 Intel target. Promote them to Tier 1 so they run on every PR. Qualcomm and the Vulkan IHV configurations remain experimental and continue to require the
test-alllabel.Recent pass rates:
Changes
docs/CI.md: PromoteWindows AMD GPU DirectXandWindows NVIDIA GPU DirectXfrom Experimental to Tier 1.README.md: Move the AMD and NVIDIA DirectX rows from Experimental Targets to Tier 1 Targets in the status table..github/workflows/pr-matrix.yaml: Fold AMD and NVIDIA D3D12 (DXC + Clang) into the existingExec-Tests-Windowsjob viaincludeso they run on every PR. NarrowExec-Tests-Extra(gated ontest-all) to AMD/NVIDIA Vulkan + all QC targets.Assisted by Claude Opus 4.7