Skip to content

[VK] Update format and XFAILs for uint64_t2/int64_t2 typed buffers #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmpeng merged 2 commits into from
Jul 20, 2026
Merged

[VK] Update format and XFAILs for uint64_t2/int64_t2 typed buffers #1377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58f2771
change vk format for uint/int64_t2, update xfail and bug link
kmpeng Jul 10, 2026
e901ab9
Merge branch 'main' into update-typedbuffer-64bit-vector-tests
kmpeng Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/API/VK/Device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,12 @@ static VkFormat getVKFormat(DataFormat Format, int Channels) {
case DataFormat::Float32:
VKFormats(SFLOAT, 32) break;
case DataFormat::Int64:
if (Channels == 2)
return VK_FORMAT_R32G32B32A32_SINT;
VKFormats(SINT, 64) break;
case DataFormat::UInt64:
if (Channels == 2)
return VK_FORMAT_R32G32B32A32_UINT;
VKFormats(UINT, 64) break;
case DataFormat::Float64:
VKFormats(SFLOAT, 64) break;
Expand Down
6 changes: 2 additions & 4 deletions test/Feature/TypedBuffer/64bit-vector.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,8 @@ DescriptorSets:
...
#--- end

# This test is failing on Vulkan due to two separate issues.
# Bug https://github.com/llvm/offload-test-suite/issues/1030
# Bug https://github.com/llvm/offload-test-suite/issues/1037
# XFAIL: Vulkan
# Bug https://github.com/microsoft/DirectXShaderCompiler/issues/8615
# XFAIL: DXC && Vulkan

# REQUIRES: Int64
# RUN: split-file %s %t
Expand Down
Loading