Skip to content

Remove XFAIL for crash in SPIRVPreLegalizer for select #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bogner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove XFAIL for crash in SPIRVPreLegalizer for select #607

bogner wants to merge 1 commit into from
+0 −15

Conversation

@bogner
Copy link
Collaborator

@bogner bogner commented Dec 5, 2025

Now that llvm/llvm-project#166642 is resolved, these tests should pass.

Icohedron
Icohedron approved these changes Dec 5, 2025
View reviewed changes
Copy link
Contributor

@Icohedron Icohedron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the test results from the runners agree. (Which so far seems to be the case)

@bogner bogner added the test-all When applied to a PR this will opt-in to additional pre-merge test configurations.. label Dec 5, 2025
@bogner
Copy link
Collaborator Author

bogner commented Dec 5, 2025

Closing and re-opening to trigger test-all

@bogner bogner closed this Dec 5, 2025
@bogner bogner reopened this Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Icohedron Icohedron Icohedron approved these changes

Assignees

No one assigned

Labels

test-all When applied to a PR this will opt-in to additional pre-merge test configurations..

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bogner @Icohedron