Fix the bug while declaring the HidListener pointer as static member of HidListener in my case(combined with firebase_core_plugin v 2.21.0)#11
Open
shixin627 wants to merge 3 commits intolocalcc:mainfrom
Conversation
Owner
|
The example should probably not contain firebase dependencies, also what is the purpose of |
Author
|
localcc:
Yes, the example shouldn't contain firebase_core plugin(I just tested on
the local), and the functions doInit/doDispose are not necessary.
Thanks
Shixin
localcc ***@***.***> 於 2023年11月7日 週二 下午4:40寫道:
… The example should probably not contain firebase dependencies, also what
is the purpose of doInit/doDispose?
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQCYNAFRBEVGJUGZID6GBLYDHXYPAVCNFSM6AAAAAA7AQM67GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJYGA2DIOJWGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
localcc:
The scenario was that I imported firebase_core v 2.21.0 into my .yaml
file without made any changes to the lib and compiled the example, and then
I got the error messages while compiling.
So I tried to make some changes the HidListener class. That is not a
necessary update. I just changed the construction and didn't enhance any
functionality feature. You don't need to upgrade your plugin. It's ok.
Thanks you for developing the plugin.
Shixin
Shixin Lin ***@***.***> 於 2023年11月8日 週三 上午9:36寫道:
… localcc:
Yes, the example shouldn't contain firebase_core plugin(I just tested on
the local), and the functions doInit/doDispose are not necessary.
Thanks
Shixin
localcc ***@***.***> 於 2023年11月7日 週二 下午4:40寫道:
> The example should probably not contain firebase dependencies, also what
> is the purpose of doInit/doDispose?
>
> —
> Reply to this email directly, view it on GitHub
> <#11 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALQCYNAFRBEVGJUGZID6GBLYDHXYPAVCNFSM6AAAAAA7AQM67GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJYGA2DIOJWGU>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when I import the plugin in flutter project with firebase_core_plugin, it showed: hid_listener_plugin_windows.obj : error LNK2001: �L�k�ѪR���~���Ÿ� "private: static class HidListener * HidListener::ListenerInstance" (?ListenerInstance@HidListener@@0PEAV1@EA) [C:\Users\GitHub\Plugins\hid_listener\example\build\windows\plugins\hid_listener\hid_listener_plugin.vcxproj]
I solved it by commented the two lines:
class FLUTTER_PLUGIN_EXPORT HidListener
{
public:
HidListener();
~HidListener();
private:
HHOOK m_keyboardHook;
HHOOK m_mouseHook;
};
And I declare the pointer directly in (hid_listener/windows/hid_listener_plugin_windows.cpp)
HidListener* ListenerInstance = nullptr;